Skip to content

Do not use deprecated zipimport.load_module on PY310 #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2022
Merged

Do not use deprecated zipimport.load_module on PY310 #1599

merged 1 commit into from
Jun 7, 2022

Conversation

@DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Jun 6, 2022

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Deprecated since 3.10:
https://docs.python.org/3/library/zipimport.html#zipimport.zipimporter.find_module

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jun 6, 2022
@DanielNoord DanielNoord added this to the 2.12.0 milestone Jun 6, 2022
@coveralls
Copy link

coveralls commented Jun 6, 2022

Pull Request Test Coverage Report for Build 2448491475

  • 15 of 16 (93.75%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 92.127%
Changes Missing Coverage Covered Lines Changed/Added Lines %
astroid/interpreter/_import/spec.py 15 16 93.75%
Files with Coverage Reduction New Missed Lines %
astroid/interpreter/_import/spec.py 1 97.77%
Totals Coverage Status
Change from base Build 2446485412: -0.003%
Covered Lines: 9326
Relevant Lines: 10123
💛 - Coveralls

@DanielNoord DanielNoord merged commit 0824812 into pylint-dev:main Jun 7, 2022
@DanielNoord DanielNoord deleted the zipimport branch June 7, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees

No one assigned

Labels

Maintenance Discussion or action around maintaining astroid or the dev workflow

Projects

None yet

Milestone

2.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielNoord @coveralls @jacobtylerwalls